Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synthetic event #36

Merged
merged 4 commits into from
Mar 3, 2019
Merged

Synthetic event #36

merged 4 commits into from
Mar 3, 2019

Conversation

tonn1o
Copy link
Contributor

@tonn1o tonn1o commented Feb 26, 2019

No description provided.

@tonn1o tonn1o changed the title synthetic event translated Synthetic event Feb 26, 2019
@netlify
Copy link

netlify bot commented Feb 26, 2019 •
edited
Loading

Deploy preview for uk-reactjs ready!

Built with commit a099752

https://deploy-preview-36--uk-reactjs.netlify.com

liashchynskyi
liashchynskyi suggested changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@liashchynskyi liashchynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klymenkoo @ApolllonDev @mihilbabin перевірте ще ви))

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
oleksii-polovyi
oleksii-polovyi requested changes Feb 28, 2019
View reviewed changes
Copy link
Member

@oleksii-polovyi oleksii-polovyi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start 👍
Please fix the suggestions from @liashchynskyi and @Kiwka.

@vldmrkl vldmrkl added API-довідка API Reference part of documentation priority: high labels Mar 2, 2019
Anton Babenko added 2 commits March 2, 2019 10:43
@tonn1o
Copy link
Contributor Author

tonn1o commented Mar 2, 2019

@ApolllonDev . All discussions resolved.

@oleksii-polovyi
Copy link
Member

@klymenkoo please review.

vldmrkl
vldmrkl requested changes Mar 2, 2019
View reviewed changes
Copy link
Member

@vldmrkl vldmrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дуже гарний початок 👍
Треба зробити ще декілька виправлень :)

content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
liashchynskyi
liashchynskyi suggested changes Mar 2, 2019
View reviewed changes
content/docs/reference-events.md Outdated Show resolved Hide resolved
content/docs/reference-events.md Outdated Show resolved Hide resolved
@vldmrkl
Copy link
Member

vldmrkl commented Mar 2, 2019

@liashchynskyi там же окремо написано начебто?

@tonn1o
Copy link
Contributor Author

tonn1o commented Mar 3, 2019

@liashchynskyi там же окремо написано начебто?

Ти просто у своєму прикладі разом написав.

@tonn1o
Copy link
Contributor Author

tonn1o commented Mar 3, 2019

@ApolllonDev @klymenkoo , all discussions are resolved

@vldmrkl
Copy link
Member

vldmrkl commented Mar 3, 2019

@TheTonnio looks good, thanks for your contribution 🙌

@vldmrkl vldmrkl merged commit 8c14034 into reactjs:master Mar 3, 2019
@tesseralis tesseralis mentioned this pull request Mar 3, 2019
Closed
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kiwka Kiwka Kiwka left review comments

@liashchynskyi liashchynskyi liashchynskyi requested changes

@vldmrkl vldmrkl vldmrkl approved these changes

@oleksii-polovyi oleksii-polovyi oleksii-polovyi approved these changes

Assignees

@tonn1o tonn1o

Labels
API-довідка API Reference part of documentation priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tonn1o @oleksii-polovyi @vldmrkl @Kiwka @liashchynskyi