Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shallow-renderer #26

Merged
merged 13 commits into from
Mar 1, 2019
Merged

shallow-renderer #26

merged 13 commits into from
Mar 1, 2019

Conversation

oleksii-polovyi
Copy link
Member

No description provided.

@oleksii-polovyi oleksii-polovyi self-assigned this Feb 24, 2019
@netlify
Copy link

netlify bot commented Feb 24, 2019 •
edited
Loading

Deploy preview for uk-reactjs ready!

Built with commit a32837e

https://deploy-preview-26--uk-reactjs.netlify.com

ithompson4
ithompson4 reviewed Feb 24, 2019
View reviewed changes
Copy link
Collaborator

@ithompson4 ithompson4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good translation

vldmrkl
vldmrkl requested changes Feb 25, 2019
View reviewed changes
Copy link
Member

@vldmrkl vldmrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 🙌
A few changes, and it'll be good

content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Show resolved Hide resolved
content/docs/addons-shallow-renderer.md Outdated Show resolved Hide resolved
@oleksii-polovyi
Copy link
Member Author

@klymenkoo, @mihilbabin previous suggestions were fixed. Please review once more.

@vldmrkl
Copy link
Member

vldmrkl commented Mar 1, 2019

Looks good, thank you @ApolllonDev

@vldmrkl vldmrkl merged commit 925f768 into reactjs:master Mar 1, 2019
@tesseralis tesseralis mentioned this pull request Mar 2, 2019
Closed
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liashchynskyi liashchynskyi liashchynskyi left review comments

@ithompson4 ithompson4 ithompson4 left review comments

@mihilbabin mihilbabin mihilbabin left review comments

@Vanuan Vanuan Vanuan left review comments

@vldmrkl vldmrkl vldmrkl approved these changes

Assignees

@oleksii-polovyi oleksii-polovyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oleksii-polovyi @vldmrkl @Vanuan @mihilbabin @ithompson4 @liashchynskyi