Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown prop #183

Merged
merged 11 commits into from
Feb 18, 2020
Merged

Unknown prop #183

merged 11 commits into from
Feb 18, 2020

Conversation

mikhailnetkachev-halolab
Copy link
Contributor

Translation of article "Unknown prop" from Warnings section.

@netlify
Copy link

netlify bot commented Dec 19, 2019

Deploy preview for uk-reactjs failed.

Built with commit 1abf948

https://app.netlify.com/sites/uk-reactjs/deploys/5e4bf6429a6dbe0009137d7f

@vldmrkl vldmrkl self-requested a review December 19, 2019 16:45
Copy link
Member

@oleksii-polovyi oleksii-polovyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start 👍

Also, please keep the source formatting (e.g. lines 136, 137) as we want to reduce the number of conflicts with https://github.com/reactjs/reactjs.org.

@mikhailnetkachev-halolab
Copy link
Contributor Author

Also, please keep the source formatting (e.g. lines 136, 137) ...

@ApolllonDev Sorry, what do you mean? What document are you talking about because this article has a total of 63 lines?

Copy link
Member

@vldmrkl vldmrkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дякую ще раз за переклад. Виглядає дуже добре, треба лише два малих виправлення зробити і можна заливати у master 🚢

content/warnings/unknown-prop.md Outdated Show resolved Hide resolved
content/warnings/unknown-prop.md Outdated Show resolved Hide resolved
@vldmrkl vldmrkl merged commit 6bb0baa into reactjs:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants