Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs[compiler]: clarify React DevTools support for Compiler Badges in React Native #7369

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

piotrski
Copy link
Contributor

Updated docs to note that React Native supports DevTools Compiler Badges from version 0.75.0, due to its custom backend.

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 4:14pm
react-dev ✅ Ready (Inspect) Visit Preview Dec 16, 2024 4:14pm

Copy link

github-actions bot commented Dec 16, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@@ -347,7 +347,7 @@ React Compiler can verify many of the Rules of React statically, and will safely

### How do I know my components have been optimized? {/*how-do-i-know-my-components-have-been-optimized*/}

[React Devtools](/learn/react-developer-tools) (v5.0+) has built-in support for React Compiler and will display a "Memo ✨" badge next to components that have been optimized by the compiler.
[React Devtools](/learn/react-developer-tools) (v5.0+) has built-in support for React Compiler and will display a "Memo ✨" badge next to components that have been optimized by the compiler. In React Native, this feature is available from version 0.75.0 onwards, since React Native bundles its own DevTools backend.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should remove the "5.0" thing and instead refer to the new React Native DevTools (default since 0.76)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think this would be better?

Suggested change
[React Devtools](/learn/react-developer-tools) (v5.0+) has built-in support for React Compiler and will display a "Memo ✨" badge next to components that have been optimized by the compiler. In React Native, this feature is available from version 0.75.0 onwards, since React Native bundles its own DevTools backend.
[React Devtools](/learn/react-developer-tools) displays a "Memo ✨" badge next to components that have been optimized by the compiler. In React Native, this feature is part of the new DevTools (default since 0.76).

@piotrski
Copy link
Contributor Author

@gaearon I think it would be better to keep the info about React Native version, just like we have info about the DevTools version, since there are still many projects using <0.75. It might mislead some as to why React DevTools v5.0+ badges are not showing up despite being available. At least, that was my idea, since I had to check the changelog to find this :)

@gaearon
Copy link
Member

gaearon commented Dec 16, 2024

"React Native DevTools" is a new brand name and it links to a new tool. Maybe it's not ideal but let's see if people get confused?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants