-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When use Class.contextType, React.createContext should be call in separate files #1590
Conversation
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Deploy preview for reactjs ready! Built with commit cbfa319 |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix grammar.
Fixed the grammar & add an demo on CodeSandBox. |
I met the same error, when I have child and context created in the same file. The solution written here solved my problem. But I would like to know if this is the standard or there will be a fix from react team? |
@aruprakshit My team met this problem, but I think the real issue is the documentation. |
As the related issue is closed and the addition targets outdated documentation, I will close this PR. |
16.6 Context API not working in class component,Issus,13969,the Class.contextType is a greet improve,but the documentation is easy to guide developers to make mistakes.