Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document class contextType as the primary consuming mechanism #1283

Merged
merged 2 commits into from
Oct 23, 2018

Conversation

sebmarkbage
Copy link
Contributor

Supersedes #1265


> Note
>
> The way changes are determined can cause some issues when passing objects as `value`: see [Caveats](#caveats).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can move this note to Provider section instead of deleting?

@reactjs-bot
Copy link

reactjs-bot commented Oct 23, 2018

Deploy preview for reactjs ready!

Built with commit 06c42f3

https://deploy-preview-1283--reactjs.netlify.com

@gaearon gaearon merged commit 896214b into reactjs:master Oct 23, 2018
@syaau
Copy link

syaau commented Nov 16, 2018

@sebmarkbage I think the document should also mention that when using the new contextType, they create conflict with libraries (like react-redux < 5.1) that hoist the non-react static properties, making the library unusable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants