Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for higher order components #196

Merged
merged 4 commits into from
Sep 4, 2017
Merged

Allow for higher order components #196

merged 4 commits into from
Sep 4, 2017

Conversation

karevn
Copy link
Contributor

@karevn karevn commented Aug 12, 2017

No description provided.

@danez
Copy link
Collaborator

danez commented Aug 12, 2017

This looks awesome and would solve #187 and #148.

Could you add a simple testcase that shows the hoc work?

@karevn
Copy link
Contributor Author

karevn commented Aug 13, 2017

OK, no prob.

@tomsturge
Copy link

@danez Is this suitable for merging? Would be great to have this if it solves the styled-components issue

@karevn
Copy link
Contributor Author

karevn commented Aug 31, 2017

@danez any input? It's hanging here for almost 3 weeks.

@danez
Copy link
Collaborator

danez commented Sep 4, 2017

I added a test to see if it works with hoist-non-react-statics and it works :). Means that redux, stylecomponents, recompose and some more will work out of the box without even setting tabsRole.

Thank you very much.

@danez danez merged commit b33fe74 into reactjs:master Sep 4, 2017
danez pushed a commit that referenced this pull request Sep 5, 2017
* Allow for higher order components

* Added tests with higher order components.

* Test if solution works with hoist-non-react-statics
danez pushed a commit that referenced this pull request Sep 5, 2017
* Allow for higher order components

* Added tests with higher order components.

* Test if solution works with hoist-non-react-statics
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants