Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom ID generators for elements #129

Closed
wants to merge 10 commits into from

Conversation

neeharv
Copy link

@neeharv neeharv commented Sep 5, 2016

Fixes #56

This is still work in progress. I need to add tests and figure out if this is a viable fix for this problem.

@adamsoffer
Copy link

Looking to use this component in my universal app as well. Would love to get this merged in!

@neeharv
Copy link
Author

neeharv commented Nov 12, 2016

I haven't heard anything on this yet, so in the meanwhile I've released
https://www.npmjs.com/package/react-tabs-isomorphic so I can start using
this in production with an isomorphic app. I'll update the pr over the
weekend with some more tweaks, but till then, anyone who wants to get it
working server side can use that lib.

On Sat 12 Nov, 2016, 11:47 PM Adam Soffer, notifications@github.com wrote:

Looking to use this component in my universal app as well. Would love to
get this merged in!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#129 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABsS4VxE_tSNTm0cY0lc8n3bHAOcsL4oks5q9gKdgaJpZM4J1Mqg
.

@pr1ntr
Copy link

pr1ntr commented Mar 29, 2017

If this works why not merge? It has been a few months.

@danez
Copy link
Collaborator

danez commented Apr 13, 2017

Instead of allowing a custom generator function, I went for a static function which allows to reset the internal counter in 88721f8

@danez danez closed this Apr 13, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server side rendering checksum error
4 participants