guard infinite loop against chained, static methods

* Add `isValidCalleeType()` check for CallExpresion and ArrayExpression and Literal * Fixes #136
reactjs · Dec 21, 2016 · 193499b · 193499b
1 parent ab37d8b
commit 193499b
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/__tests__/fixtures/component_2.js b/src/__tests__/fixtures/component_2.js
@@ -21,3 +21,15 @@ export class Button extends React.Component {
     };
   }
 }
+
+export function foo() {
+  return [].join();
+}
+
+export function chained() {
+  return foo.bar().join();
+}
+
+export function templateLiteral() {
+  return `foo bar`.split(' ');
+}
diff --git a/src/utils/isStatelessComponent.js b/src/utils/isStatelessComponent.js
@@ -28,6 +28,16 @@ const validPossibleStatelessComponentTypes = [
   'ArrowFunctionExpression',
 ];
 
+function isValidCalleeType(type) {
+  return [
+    'Identifier',
+    'CallExpression',
+    'ArrayExpression',
+    'TemplateLiteral',
+    'Literal'
+  ].indexOf(type) < 0;
+}
+
 function isJSXElementOrReactCreateElement(path) {
   return (
     path.node.type === 'JSXElement' ||
@@ -94,7 +104,7 @@ function returnsJSXElementOrReactCreateElementCall(path) {
             resolvedValue = resolveToValue(calleeValue.get('object'));
           }
           else {
-            while (calleeValue.get('object').node.type !== 'Identifier') {
+            while (isValidCalleeType(calleeValue.get('object').node.type)) {
               calleeValue = calleeValue.get('object');
               namesToResolve.unshift(calleeValue.get('property'));
             }