Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate DOM Elements #67

Merged
merged 18 commits into from
Jun 7, 2019
Merged

Translate DOM Elements #67

merged 18 commits into from
Jun 7, 2019

Conversation

stepover10
Copy link
Contributor

@stepover10 stepover10 commented Mar 10, 2019

Progress

@netlify
Copy link

netlify bot commented Mar 10, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 0854582

https://deploy-preview-67--ko-reactjs-org.netlify.com

@taehwanno
Copy link
Member

master에 모든 링크가 http -> https로 변경되어 직접 충돌 해결했습니다.

@simsim0709
Copy link
Collaborator

체크리스트가 다 체크되어 있지 않은데, 아직 완료 전이신건가요?
@stepover10

@stepover10
Copy link
Contributor Author

체크리스트가 다 체크되어 있지 않은데, 아직 완료 전이신건가요?
@stepover10

넵 아직 확인전입니다

Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

체크리스트 확인 후, 상태변경부탁드립니다.

hg-pyun
hg-pyun previously approved these changes Mar 24, 2019
@simsim0709
Copy link
Collaborator

@stepover10 님. 체크리스트는 다 체크되어 있는데 전체적으로 용어 확인과 번역 투의 느낌이 나는 곳이 있는 것 같습니다.
고생 하셨는데, 시간 되시면 한 번만 더 체크 부탁드릴게요 👍

@stepover10
Copy link
Contributor Author

stepover10 commented Mar 26, 2019

피드백 감사합니다 :)

content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
content/docs/reference-dom-elements.md Outdated Show resolved Hide resolved
@taehwanno
Copy link
Member

image

리뷰드린 사항 중 몇 가지가 누락된 것 같아요. 확인 부탁드려요. Load more을 누르시면 코멘트를 불러오실 수 있습니다.

@stepover10
Copy link
Contributor Author

image

리뷰드린 사항 중 몇 가지가 누락된 것 같아요. 확인 부탁드려요. Load more을 누르시면 코멘트를 불러오실 수 있습니다.

넵 중간 과정까지 일단 작업한 부분 올려놨다가 오늘 다시 또 올립니다.
리뷰 및 친절한 코멘트 감사합니다 :)

taehwanno
taehwanno previously approved these changes Jun 6, 2019
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 직접 몇 가지 수정해서 올렸어요. 고생하셨습니다.

@simsim0709 simsim0709 self-requested a review June 7, 2019 11:06
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"웹 컴포넌트 React with Web Components (which is uncommon)을 사용하는 경우 class 어트리뷰트를 사용하세요."

이 부분 번역이 제대로 안된것 같아 아래와 같이 직접 번역 했습니다.

"일반적이진 않지만, React를 웹 컴포넌트에 사용하는 경우 class 어트리뷰트를 사용하세요."

수고 많으셨습니다. 👍

@taehwanno @stepover10

@simsim0709 simsim0709 requested a review from taehwanno June 7, 2019 11:09
@taehwanno taehwanno merged commit 81e13e8 into reactjs:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants