Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Rules of Hooks #63

Merged
merged 12 commits into from
Mar 22, 2019
Merged

Translate Rules of Hooks #63

merged 12 commits into from
Mar 22, 2019

Conversation

BeomyeonAndrewKim
Copy link
Contributor

@BeomyeonAndrewKim BeomyeonAndrewKim commented Mar 4, 2019 •
edited
Loading

Progress

@netlify
Copy link

netlify bot commented Mar 4, 2019 •
edited
Loading

Deploy preview for ko-reactjs-org ready!

Built with commit d6ab00c

https://deploy-preview-63--ko-reactjs-org.netlify.com

@tesseralis tesseralis mentioned this pull request Mar 4, 2019
Open
gnujoow
gnujoow previously requested changes Mar 6, 2019
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞춤법 오류가 있어 바로 잡습니다. ;)

content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
@BeomyeonAndrewKim
Copy link
Contributor Author

@gnujoow 수정 완료했습니다. 리뷰 감사합니다 :)

gnujoow
gnujoow reviewed Mar 6, 2019
View reviewed changes
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
taggon
taggon reviewed Mar 6, 2019
View reviewed changes
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
@BeomyeonAndrewKim
Copy link
Contributor Author

@taggon @gnujoow 리뷰 및 제안 주셔서 감사합니다. 수정 완료했습니다 :)

hg-pyun
hg-pyun approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simsim0709 simsim0709 self-requested a review March 22, 2019 01:46
simsim0709
simsim0709 approved these changes Mar 22, 2019
View reviewed changes
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

@simsim0709 simsim0709 dismissed gnujoow’s stale review March 22, 2019 01:47

수정 확인되어 제가 머지하겠습니다.

@simsim0709 simsim0709 merged commit d49f15a into reactjs:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnujoow gnujoow gnujoow left review comments

@taggon taggon taggon left review comments

@hg-pyun hg-pyun hg-pyun approved these changes

@simsim0709 simsim0709 simsim0709 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@BeomyeonAndrewKim @taggon @simsim0709 @hg-pyun @gnujoow @taehwanno @BeomyeonKim