Translate Components and Props #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simsim0709
reviewed
Feb 18, 2019
simsim0709
reviewed
Feb 18, 2019
simsim0709
reviewed
Feb 18, 2019
simsim0709
reviewed
Feb 18, 2019
content/docs/components-and-props.md
Outdated
|
|
||
| ## Composing Components {#composing-components} | ||
| ## 컴포넌트 구성 {#composing-components} |
There was a problem hiding this comment.
여기서는 "컴포넌트 구성" 보다는 "컴포넌트 합성"이 낫지 않을까요?
There was a problem hiding this comment.
현재 세션 이후에 composition에 대한 세션이 나와서 "구성"으로 번역할지 "조립"으로 번역할지 고민했었는데, 제안해주신 "컴포넌트 합성"이 괜찮은 것 같습니다. 수정했습니다. 감사합니다!
gnujoow
requested changes
Feb 21, 2019
gnujoow
requested changes
Feb 21, 2019
content/docs/components-and-props.md
Outdated
|
|
||
| ## Function and Class Components {#function-and-class-components} | ||
| ## 함수 및 클래스 컴포넌트 {#function-and-class-components} |
There was a problem hiding this comment.
함수 컴포넌트와 클래스 컴포넌트
로 제안합니다. 함수 및 클래스 컴포넌트는 함수 | 클래스 컴포넌트 두가지로 분리되서 받아들여질 수 있을것 같아서요
There was a problem hiding this comment.
넵 함수 및 클래스 컴포넌트는 중의적인것 같네요. 함수 컴포넌트와 클래스 컴포넌트로 수정했습니다. 감사합니다!
added 7 commits
February 22, 2019 21:26
(함수 및 클래스 컴포넌트 -> 함수 컴포넌트와 클래스 컴포넌트)
|
Deploy preview for ko-reactjs-org ready! Built with commit 793d11e |
|
Deploy preview for ko-reactjs-org ready! Built with commit 09ec201 |
컴포넌트 구성 -> 컴포넌트 합성
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress