Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Codebase Overview #123

Merged
merged 13 commits into from
Oct 16, 2019
Merged

Translate Codebase Overview #123

merged 13 commits into from
Oct 16, 2019

Conversation

Kimguyeop
Copy link
Contributor

@Kimguyeop Kimguyeop commented May 22, 2019 •
edited
Loading

@netlify
Copy link

netlify bot commented May 22, 2019 •
edited
Loading

Deploy preview for ko-reactjs-org ready!

Built with commit e86b844

https://deploy-preview-123--ko-reactjs-org.netlify.com

@taehwanno taehwanno changed the title Translate Translate Codebase Overview May 23, 2019
@tesseralis tesseralis mentioned this pull request May 23, 2019
Open
hg-pyun
hg-pyun requested changes Jun 24, 2019
View reviewed changes
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
@Kimguyeop
Copy link
Contributor Author

수정해서 올렸습니다. 좋은 의견 감사합니다. !

hg-pyun
hg-pyun previously approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@taehwanno 시간되시면 +1 리뷰 부탁드립니다 :)

taehwanno
taehwanno requested changes Jul 27, 2019
View reviewed changes
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작은 수정사항 몇 가지 남겼습니다!

content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
content/docs/codebase-overview.md Outdated Show resolved Hide resolved
@Kimguyeop
Copy link
Contributor Author

수정해서 올렸습니다. 좋은 의견 감사합니다.

gnujoow
gnujoow approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 고생많으셨습니다.

@gnujoow gnujoow merged commit 97cb8d8 into reactjs:master Oct 16, 2019
@gnujoow gnujoow mentioned this pull request Nov 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnujoow gnujoow gnujoow approved these changes

@taehwanno taehwanno taehwanno approved these changes

@hg-pyun hg-pyun hg-pyun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kimguyeop @taehwanno @hg-pyun @gnujoow