Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate components/LayoutFooter #122

Merged
merged 6 commits into from
Jul 3, 2019
Merged

Translate components/LayoutFooter #122

merged 6 commits into from
Jul 3, 2019

Conversation

hoony2520
Copy link
Contributor

@netlify
Copy link

netlify bot commented May 22, 2019 •
edited
Loading

Deploy preview for ko-reactjs-org ready!

Built with commit 2a9d8e3

https://deploy-preview-122--ko-reactjs-org.netlify.com

@taehwanno taehwanno changed the title Translate Translate components/LayoutFooter May 23, 2019
@taehwanno
Copy link
Member

CircleCI 빌드 결과에서 Prettier 관련 포맷팅이 깨진걸 알 수 있어요. 확인 후 수정 부탁드려요 :)

@tesseralis tesseralis mentioned this pull request May 23, 2019
Open
@hoony2520
Copy link
Contributor Author

CircleCi 설정을 어떻게 바꿔야 되는지 모르겠는데 죄송하지만 혹시 어떻게 해야 하는지 아시나요?

taehwanno
taehwanno reviewed Jun 5, 2019
View reviewed changes
src/components/LayoutFooter/Footer.js Outdated
Acknowledgements
</FooterLink>
<MetaTitle onDark={true}>더보기</MetaTitle>
<FooterLink to="/tutorial/tutorial.html">튜토리얼</FooterLink>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutorial 목차와 통일하기 위해 튜토리얼 -> 자습서로 변경 부탁드려요.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

직접 수정했습니다.

@taehwanno
Copy link
Member

제가 직접 수정해서 푸쉬했어요!

image

추가적으로 설명드리면 위 사진처럼 커밋 해쉬(0990a91) 옆의 빨간 X를 클릭해서 볼 수 있는 CircleCI 빌드 결과를 살펴보시면 Check Prettier, ESLint, Flow 단계에서 prettier를 실행하다가 빌드가 깨진 것을 알 수 있어요. Prettier는 코드 포맷을 모든 파일에서 일관성있게 맞추기 위해 사용하는 도구에요. package.json에 있는 yarn prettier 스크립트를 실행해서 커밋 후 푸쉬했습니다.

hg-pyun
hg-pyun previously approved these changes Jun 11, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hg-pyun
Copy link
Member

hg-pyun commented Jul 2, 2019

@taehwanno Merge해도 될것같은데, 확인 부탁드립니다!

@taehwanno taehwanno merged commit befddf1 into reactjs:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taehwanno taehwanno taehwanno left review comments

@hg-pyun hg-pyun hg-pyun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoony2520 @taehwanno @hg-pyun