Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Lifting State Up #109

Merged
merged 5 commits into from
Jun 2, 2019
Merged

Translate Lifting State Up #109

merged 5 commits into from
Jun 2, 2019

Conversation

chayeoi
Copy link
Collaborator

@chayeoi chayeoi commented May 1, 2019 •
edited by taehwanno
Loading

Lifting State Up 번역입니다. 개인 사정으로 생각보다 많이 늦어졌네요 ㅜ..

해당 섹션의 제목이 현재 "State 올리기"로 번역되어있는데, "State 끌어올리기"로 번역하는 것이 좀 더 느낌을 잘 살리는 표현이지 않나 싶습니다.

Progress

@chayeoi chayeoi self-assigned this May 1, 2019
@netlify
Copy link

netlify bot commented May 1, 2019 •
edited
Loading

Deploy preview for ko-reactjs-org ready!

Built with commit a09ed71

https://deploy-preview-109--ko-reactjs-org.netlify.com

@tesseralis tesseralis mentioned this pull request May 6, 2019
Open
@chayeoi chayeoi requested a review from taehwanno May 6, 2019 10:56
gnujoow
gnujoow requested changes May 6, 2019
View reviewed changes
content/docs/lifting-state-up.md Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
taehwanno
taehwanno reviewed May 13, 2019
View reviewed changes
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
content/docs/lifting-state-up.md Outdated Show resolved Hide resolved
hg-pyun
hg-pyun reviewed May 15, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맞춤법 검사 한번 부탁드립니다 :)

@taehwanno taehwanno mentioned this pull request May 29, 2019
Closed
@simsim0709 simsim0709 requested a review from gnujoow May 30, 2019 08:26
@taehwanno taehwanno merged commit 8aa6505 into reactjs:master Jun 2, 2019
@taehwanno
Copy link
Member

고생하셨습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

@taehwanno taehwanno taehwanno approved these changes

@gnujoow gnujoow Awaiting requested review from gnujoow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chayeoi @taehwanno @hg-pyun @gnujoow