-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore textlint, as a subpackage #580
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smikitky
added
the
workflow
Working environment improvements including linting and CSS styles
label
May 16, 2023
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
smikitky
commented
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
リポジトリルートにあった旧サイト用設定ファイルなので削除
7 tasks
koba04
approved these changes
May 25, 2023
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Textlint によるコミット前フックを復活させます。
新しく前は設定系ファイルのみがあったtextlint
ディレクトリを作りtextlint
ディレクトリに新しくpackage.json
,yarn.lock
などを配置し、別パッケージとして textlint をセットアップしました。こちらの新しいpackage.json
にも script が複数あり単体で動きますが、人間が直接これを打つことはあまり想定していません。textlint
,textlint-staged
というスクリプトを追加しました。これらは、cd textlint && yarn install --frozen-lockfile
してからサブパッケージ上の同名スクリプトを起動するものです。従ってリポジトリルートで単にyarn textlint
するだけで textlint が動きます。初回のみ少し遅いですが、人間が手動で何かをセットアップする必要はないはずです。yarn fix-headings
を実行するようになっていました。なのでそこに更に(リポジトリルートで)yarn textlint-staged
するステップを追加しました。ルートの
yarn.lock
には一切触れていないので将来のマージで悩む必要はなさそうです。注意点