Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate testing-recipes #261

Merged
merged 4 commits into from
Oct 30, 2019
Merged

Translate testing-recipes #261

merged 4 commits into from
Oct 30, 2019

Conversation

smikitky
Copy link
Member

一応理解して訳したつもりではありますが、実は React のテストは実際にやったことがない領域なので、経験のある方の確認をいただければ助かります。

nav.yaml への更新も含んでいます。

@smikitky smikitky force-pushed the tr/testing-recipes branch 2 times, most recently from e77780b to a7f4bb9 Compare October 24, 2019 10:40
@netlify
Copy link

netlify bot commented Oct 24, 2019 •
edited
Loading

Deploy preview for ja-reactjs ready!

Built with commit d1afac9

https://deploy-preview-261--ja-reactjs.netlify.com

@smikitky smikitky marked this pull request as ready for review October 24, 2019 10:57
@smikitky smikitky requested review from koba04 and potato4d October 24, 2019 10:57
@smikitky smikitky changed the title Trnslate testing-recipes Translate testing-recipes Oct 24, 2019
@reactjs reactjs deleted a comment from netlify bot Oct 24, 2019
@reactjs reactjs deleted a comment from netlify bot Oct 24, 2019
potato4d
potato4d approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

私も React のテストは airbnb/enzyme を利用した少し古いものまでしか詳しい部分は把握していませんが、ざっと見た感じ問題なさそうです。
翻訳ありがとうございます！

いくつか nits と memo を書きました。

content/docs/testing-recipes.md Outdated Show resolved Hide resolved
content/docs/testing-recipes.md Show resolved Hide resolved
content/docs/testing-recipes.md Outdated Show resolved Hide resolved
koba04
koba04 approved these changes Oct 27, 2019
View reviewed changes
Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 特に気になる点はありませんでした！

potato4d
potato4d approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです。ありがとうございます！

@tesseralis tesseralis mentioned this pull request Oct 28, 2019
Closed
90 tasks
@smikitky smikitky merged commit bff2faa into master Oct 30, 2019
@smikitky smikitky deleted the tr/testing-recipes branch October 30, 2019 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potato4d potato4d potato4d approved these changes

@koba04 koba04 koba04 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smikitky @koba04 @potato4d