Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify category format in frontmatter #110

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

satotake
Copy link
Contributor

@satotake satotake commented Feb 11, 2019

Related #4
Very tiny PR.

Background

I wondered if category' s value (such as Reference or Add-ons) in frontmatter should be translated.
I found that members had also mentioned in #21 .
But it remains unclear if they should be translated or not.
I studied how they are used in this repo.

Conclusion

The values of category are not used anywhere in reactjs.org at least for now.
Therefore, whichever is ok currently.
It will be better not to translate them and leave them as they are, considering they might be used for unknown purposes in the future.

I checked

  • no strings of category in public dir after building sites
  • no GraphQL query containing category
  • Node type in src/types.js does not have category
  • In gatsby dir, only redirect_from and permalink are used as frontmatter value
  • Backend seach engine is docsearch, which use only html files as data source

@smikitky
Copy link
Member

Thank you, this should have been mentioned in the TRANSLATION.md. Many *.md files lack this field in the first place, so I also think this is an unimportant field for now.

Copy link
Member

@koba04 koba04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@koba04 koba04 merged commit 5c0f759 into reactjs:master Feb 12, 2019
@koba04
Copy link
Member

koba04 commented Feb 12, 2019

@satotake mergeしました!ありがとうございます! 🚀🚀

@smikitky smikitky mentioned this pull request Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants