Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traduzione nuova HomePage #417

Merged
merged 9 commits into from
Apr 21, 2023
Merged

Traduzione nuova HomePage #417

merged 9 commits into from
Apr 21, 2023

Conversation

deblasis
Copy link
Collaborator

No description provided.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.28 KB (🟡 +290 B) 169.91 KB
/500 76.28 KB (🟡 +290 B) 169.91 KB
/[[...markdownPath]] 77.7 KB (🟡 +290 B) 171.33 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.28 KB (🟡 +290 B) 169.91 KB
/500 76.28 KB (🟡 +290 B) 169.91 KB
/[[...markdownPath]] 77.7 KB (🟡 +290 B) 171.33 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.37 KB (🟡 +379 B) 170 KB
/500 76.37 KB (🟡 +379 B) 169.99 KB
/[[...markdownPath]] 77.79 KB (🟡 +379 B) 171.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link
Collaborator

@mattia-sanfilippo mattia-sanfilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie!! 😃 👍

src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/HomeContent.js Outdated Show resolved Hide resolved
src/components/Layout/Footer.tsx Show resolved Hide resolved
src/components/Layout/Footer.tsx Show resolved Hide resolved
src/components/Layout/Footer.tsx Show resolved Hide resolved
src/components/Layout/Footer.tsx Show resolved Hide resolved
src/components/Layout/HomeContent.js Show resolved Hide resolved
deblasis and others added 3 commits April 21, 2023 08:08
Co-authored-by: Mattia Sanfilippo <info@mattiasanfilippo.com>
Co-authored-by: Mattia Sanfilippo <info@mattiasanfilippo.com>
Co-authored-by: Mattia Sanfilippo <info@mattiasanfilippo.com>
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.37 KB (🟡 +380 B) 170 KB
/500 76.37 KB (🟡 +380 B) 170 KB
/[[...markdownPath]] 77.79 KB (🟡 +380 B) 171.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

2 similar comments
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.37 KB (🟡 +380 B) 170 KB
/500 76.37 KB (🟡 +380 B) 170 KB
/[[...markdownPath]] 77.79 KB (🟡 +380 B) 171.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.37 KB (🟡 +380 B) 170 KB
/500 76.37 KB (🟡 +380 B) 170 KB
/[[...markdownPath]] 77.79 KB (🟡 +380 B) 171.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.37 KB (🟡 +380 B) 170 KB
/500 76.37 KB (🟡 +380 B) 170 KB
/[[...markdownPath]] 77.79 KB (🟡 +380 B) 171.42 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@deblasis
Copy link
Collaborator Author

@mattia-sanfilippo grazie per la review 🙏
Riguardo le maiuscole, in linea di principio concordo ma volevo mantenere lo stile editoriale scelto dal team React.
Ti ho convinto?

@mattia-sanfilippo
Copy link
Collaborator

@deblasis concordo! 😄 manteniamo il loro stesso stile 💪

@deblasis
Copy link
Collaborator Author

@mattia-sanfilippo quando hai finito con la review per favore approvala o richiedi cambiamenti cosi mergiamo!

Copy link
Collaborator

@mattia-sanfilippo mattia-sanfilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 💪

@deblasis deblasis merged commit 73e6e19 into main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants