Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Glossary to Indonesian #36

Merged
merged 6 commits into from
Jul 21, 2020

Conversation

hilalarsa
Copy link
Contributor

Thanks for giving me chance to contribute and translate the page.

@netlify
Copy link

netlify bot commented Feb 19, 2019

Deploy preview for idreactjs ready!

Built with commit d72271c

https://deploy-preview-36--idreactjs.netlify.com

Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hilalarsa Thank you for the contribution! 🎉 , So sorry I hadn't been able to review your PR this past week, there's several typo and diction that needs to be fixed (also needed your opinion regarding some of the diction). After that i think it's LGTM! 🎉

content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Mar 3, 2019

Deploy preview for id-reactjs ready!

Built with commit d72271c

https://deploy-preview-36--id-reactjs.netlify.com

@gedeagas gedeagas requested a review from rizafahmi April 12, 2019 12:39

Bundlers take JavaScript and CSS code written as separate modules (often hundreds of them), and combine them together into a few files better optimized for the browsers. Some bundlers commonly used in React applications include [Webpack](https://webpack.js.org/) and [Browserify](http://browserify.org/).
_Bundler_ menggunakan kode JavaScript dan CSS yang ditulis di modul terpisah, dan menggabungkannya menjadi beberapa file yang lebih optimal untuk dijalankan oleh peramban. _Bundler_ yang sering digunakan React meliputi [Webpack](https://webpack.js.org/) dan [Browserify](http://browserify.org/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Browser need to translate to peramban?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other docs doesn't change browser to peramban. Here are some references from the master branch:


## [Controlled](/docs/forms.html#controlled-components) vs. [Uncontrolled Components](/docs/uncontrolled-components.html)

React has two different approaches to dealing with form inputs.
React memiliki dua pendekatan berbeda untuk mengatur masukan formulir.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that necessary to translate form into formulir?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you think @regalius?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
React memiliki dua pendekatan berbeda untuk mengatur masukan formulir.
React memiliki dua pendekatan berbeda untuk mengatur inputan form.

Maybe this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inputan form sounds better IMO.


Bundlers take JavaScript and CSS code written as separate modules (often hundreds of them), and combine them together into a few files better optimized for the browsers. Some bundlers commonly used in React applications include [Webpack](https://webpack.js.org/) and [Browserify](http://browserify.org/).
_Bundler_ menggunakan kode JavaScript dan CSS yang ditulis di modul terpisah, dan menggabungkannya menjadi beberapa file yang lebih optimal untuk dijalankan oleh peramban. _Bundler_ yang sering digunakan React meliputi [Webpack](https://webpack.js.org/) dan [Browserify](http://browserify.org/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other docs doesn't change browser to peramban. Here are some references from the master branch:


## Package Managers {#package-managers}
## Manajer Paket {#package-managers}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stick to "Package Manager" 👍


## [Controlled](/docs/forms.html#controlled-components) vs. [Uncontrolled Components](/docs/uncontrolled-components.html)

React has two different approaches to dealing with form inputs.
React memiliki dua pendekatan berbeda untuk mengatur masukan formulir.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inputan form sounds better IMO.

@resir014 resir014 merged commit 2ae8774 into reactjs:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants