Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated Hooks at a Glance (closed b/c force-push) #34

Closed
wants to merge 0 commits into from
Closed

Translated Hooks at a Glance (closed b/c force-push) #34

wants to merge 0 commits into from

Conversation

grikomsn
Copy link
Member

This is a translation PR for the Hooks at a Glance page. Heavy review and changes are needed. Here are some somewhat important notes:

  • Lifecycle, data fetching, subscriptions, subscribe, unsubscribe, and other words are kept as is
  • Hooks and Hook are all italicized, which previously aren't
  • Effect Hook is translated to Hook Effect, State Hook turns to Hook State
  • Several sentence adjustment far from original text for better understanding

@netlify
Copy link

netlify bot commented Feb 19, 2019 •
edited
Loading

Deploy preview for idreactjs ready!

Built with commit 4fe9314

https://deploy-preview-34--idreactjs.netlify.com

@grikomsn
Copy link
Member Author

So much typos, I should sleep more often. I'll revise some typos and others. 😄

@grikomsn
Copy link
Member Author

Corrected, thanks for the heads up. 😄

@grikomsn
Copy link
Member Author

Pardon for asking, but how long is the review process for each PR?

cc @regalius @arfianadam @gedeagas

@regalius
Copy link
Member

So sorry @grikomsn I had a busy week and haven't been able to review the PRs, I assume both @gedeagas and @arfianadam had busy week also, will review now.. 🙏

regalius
regalius requested changes Feb 24, 2019
View reviewed changes
Copy link
Member

@regalius regalius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @grikomsn , Thank you for the contribution 🎉 , so sorry I had a busy week and wasn't able to review your PR, There's several terms and diction that I think need another consideration (and I need your opinion about it) and it'll be good to go!

content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
content/docs/hooks-overview.md Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
@netlify
Copy link

netlify bot commented Feb 24, 2019 •
edited
Loading

Deploy preview for id-reactjs ready!

Built with commit 4fe9314

https://deploy-preview-34--id-reactjs.netlify.com

@grikomsn
Copy link
Member Author

This goes to show that I can't write in my native language properly 😅

regalius
regalius approved these changes Mar 3, 2019
View reviewed changes
Copy link
Member

@regalius regalius left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me.. Nice Work @grikomsn ! No worries lol

Thanks for the contribution! 🎉

Any comments guys @arfianadam @gedeagas ?

Edited: Btw please resolve the conflict with the upstream regarding the yarn.lock before we can merge this PR 😄

@tesseralis tesseralis mentioned this pull request Mar 3, 2019
Closed
96 tasks
@gedeagas
Copy link
Member

LGTM for the translation. can you remove the yarn lock @grikomsn ?

@grikomsn
Copy link
Member Author

grikomsn commented Mar 18, 2019 •
edited
Loading

I have already removed the yarn.lock file, but somehow the build fails. Pushed an empty commit to trigger the build.

Force pushed my work with modified and cherrypicked commits. Let's see if it works. 😢

@grikomsn
Copy link
Member Author

Checks passed! Probably best that @regalius, @gedeagas, @spondbob, and other reviewers to re-review the commits again since I force pushed the commits. 😄

@grikomsn grikomsn closed this Jun 30, 2019
@grikomsn
Copy link
Member Author

Closed this issue because of accidental force push. Will submit another PR with other translations. 🙏

@grikomsn grikomsn changed the title Translated Hooks at a Glance Translated Hooks at a Glance (closed b/c force-push) Jun 30, 2019
@grikomsn grikomsn mentioned this pull request Jul 7, 2019
Merged
resir014 added a commit that referenced this pull request Jul 8, 2019
@resir014
Translate Hooks at a Glance (#88)
2a24119 
* Restore`hooks-overview` translation progress from #34

* Apply suggestions from code review

Co-Authored-By: Resi Respati <resir014@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsnotrisky itsnotrisky itsnotrisky left review comments

@gedeagas gedeagas gedeagas approved these changes

@regalius regalius regalius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grikomsn @regalius @gedeagas @itsnotrisky