Translating component-and-props page #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have finished translating this page. Kindly review this page |
96 tasks
regalius
requested changes
Feb 12, 2019
arfianadam
requested changes
Feb 17, 2019
|
Deploy preview for idreactjs ready! Built with commit e86b12f |
arfianadam
requested changes
Feb 18, 2019
regalius
requested changes
Mar 3, 2019
There was a problem hiding this comment.
Hi mas @andreepratama27 , any update regarding this PR? Also noticed that there's conflict between the translation with the upstream, please resolve conflict and provide updated translation 😄
|
Deploy preview for id-reactjs ready! Built with commit e86b12f |
regalius
approved these changes
Mar 9, 2019
There was a problem hiding this comment.
LGTM from me, Thanks for the contribution mas @andreepratama27 ! 🎉
Any other comments? @arfianadam @gedeagas @rizafahmi
|
Welcome mas @regalius 👍 Thanks for let me contribute to this great project. Also give many thanks to @gedeagas @arfianadam 🎉 For any review, just let me know |
gedeagas
approved these changes
Mar 18, 2019
|
@regalius looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.