-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate Virtual DOM and Internals #130
Conversation
Deploy preview for idreactjs ready! Built with commit 8f50cbf |
Deploy preview for id-reactjs ready! Built with commit 8f50cbf |
@zweimach It's okay! I was about to free up some inactive pages in the master issue tonight, but thank you for jumping the gun. I'll update the master issue and read into your changes later tonight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zweimach! There are some things to fix before merging.
@resir014, thank you for your feedback. |
@zweimach Thanks! I'll take a look shortly. Oh, while you're at it, don't forget to translate the page title as well. Let's use Virtual DOM dan Internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, I missed this one fix during my last review. If this was fixed this should be good to merge. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good now. Thanks!
Originally this part was claimed by @mekhanix, but since there was no update from the original claimer, I decided to help out. Please forgive my rudeness. And please review my translation.