Translate State as a Snapshot #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arshadkazmi42 please review it |
|
Thank you for working on this. I will get to it asap. |
|
@arshadkazmi42 please review it |
arshadkazmi42
requested changes
Aug 8, 2023
There was a problem hiding this comment.
Thank you for working on this.
I have added review till line 100.
Lets get these fixed and then we can continue further with the review.
Also, refer to our review guidelines #23
Title translation
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
arshadkazmi42
requested changes
May 11, 2024
review changes
arshadkazmi42
requested changes
May 11, 2024
review changes till line number 313
arshadkazmi42
requested changes
May 11, 2024
review changes till line no 432
arshadkazmi42
approved these changes
May 12, 2024
There was a problem hiding this comment.
Great work @PriyankaBelhekar77
Thank you for making all the changes.
PR looks good now and we can get this merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have translated the State as a Snapshot page. Please review it