-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hindi translation to this page is complete, pushing for review #175
Hindi translation to this page is complete, pushing for review #175
Conversation
Thank you for this @lucifertrj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
I have added comments till like 40.
Lets get these closed, then I will continue further with the review.
Also for our reviewing guidelines you can refer this #23
@arshadkazmi42, I have committed the changes. You can review it. |
Thanks for the fixes @lucifertrj I have added one comment on existing review comment. Can you check that #175 (comment) |
I apologize for missing it out @arshadkazmi42. I have updated the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
Add review till line 113.
Lets get these fixed, then we can continue further review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good going.
Added reviews till line 149.
Lets get these fixed, then we can continue further
@arshadkazmi42, what am I supposed to do further, I already committed the changes till line 148 |
@lucifertrj Sorry for delay. I will review the pending file ASAP. |
Sorry for the inconvenience, can I know if the review is done? |
Size Changes📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 One Page Changed SizeThe following page changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added review till line 383
@arshadkazmi42 Changes done till 383 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on all the fixes.
I have added the review for rest of the file.
Once these are done, we can merge this PR
@lucifertrj you have missed few comments. can you work on those. |
@arshadkazmi42 done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🚀
Thank you for working on all the fixes.
Lets get this merged 🎉
Thank you so much, you have been a great help |
Hindi Translation For
JavaScript In JSX With Curly Brackets
Is Done, Opening Pull Request For Review