Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traduction de la page "Forms" #19

Merged
merged 4 commits into from
Feb 14, 2019
Merged

Conversation

tlenclos
Copy link
Contributor

Hello ! 👋
Voici un premier jet pour la page des formulaires https://reactjs.org/docs/forms.html

@tdd tdd added the Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR label Feb 13, 2019
@tdd tdd self-requested a review February 13, 2019 14:10
Copy link
Collaborator

@tdd tdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salut @tlenclos !

Avant toute chose, merci pour tout ce boulot ! C'est super cool de nous filer un coup de main. Et de fait, il y a beaucoup de bonnes choses et de formulations bien fichues dans ton travail.

Après, c'est ta première, et je suis super exigeant, donc forcément tu trouveras plein de petites retouches, d'autant que c'est un texte assez difficile.

Tout est fait sous forme de Suggestions GitHub, il te suffit à chaque suggestion que tu approuves de cliquer le bouton d'ajout au lot de modifs à committer, et sur la fin de créer le commit groupé.

Si certaines appellent discussion, n'hésite pas, tu réponds, on en parle, on avance ensemble 🤝

Quand tout sera bouclé côté code, je ferai une repasse visuelle finale en local avant de fusionner.

Encore mille mercis, j'ai hâte de voir cette PR finalisée et dans master !

content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
content/docs/forms.md Outdated Show resolved Hide resolved
@tdd tdd added Reviewed and removed Pending Review Un mainteneur qualifié doit encore faire la revue de cette PR labels Feb 13, 2019
tdd and others added 2 commits February 13, 2019 21:32
Co-Authored-By: tlenclos <tlenclos@users.noreply.github.com>
@tdd
Copy link
Collaborator

tdd commented Feb 13, 2019

@tlenclos tu peux mettre à jour ton entrée dans docs/nav.yml par ailleurs ? « Formulaires »

@tdd
Copy link
Collaborator

tdd commented Feb 13, 2019

@tlenclos attention j'ai ajouté un commit via GitHub, ne force-pushe pas, pull --rebase plutôt avant ton push !

@tdd
Copy link
Collaborator

tdd commented Feb 14, 2019

@tlenclos je merge, on calera la nav plus tard.

@tdd tdd merged commit a750ad1 into reactjs:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants