Adding translation to react-dom: APIs #664
Merged
+14
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateoguzmana
approved these changes
Apr 28, 2023
carburo
requested changes
May 3, 2023
| @@ -18,7 +18,7 @@ interface ExpandableCalloutProps { | |||
|
|
|||
| const variantMap = { | |||
| deprecated: { | |||
| title: 'Deprecated', | |||
| title: 'Obsoleto', | |||
There was a problem hiding this comment.
Por favor, ¿podrías revertir este cambio?
La recomendación del equipo de React es no traducir elementos de la UI de momento para evitar conflictos en el futuro:
Keep in mind translating UI is best done closer to the end. We plan to make non-trivial code changes to the repo over the next few months. So it's best to focus on the content rather than on UI components.
|
|
||
| <Deprecated> | ||
|
|
||
| These APIs will be removed in a future major version of React. | ||
| Las siguientes APIs se eliminarán en las próximas versiones importantes de React. |
There was a problem hiding this comment.
Para mantener la consistencia en todas las páginas estamos utilizando la terminología mayor.menor.parche.
Suggested change
| Las siguientes APIs se eliminarán en las próximas versiones importantes de React. | |
| Las siguientes APIs se eliminarán en una próxima versión mayor de React. |
|
Apliqué los cambios @carburo |
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Traducción de react-dom: APIs. Atenderé cualquier revisión lo antes posible.