Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StrictMode translation to spanish #656

Merged
merged 8 commits into from
May 4, 2023

Conversation

Dazzae-exe
Copy link
Contributor

Strict Mode

  • Traducción a español de su doc.

Encantado de corregir algún cambio que se necesite asap.

@Dazzae-exe
Copy link
Contributor Author

@carburo Buen día carburo, espero puedas chequear el PR en cualquier momento. Saludos y un gran comienzo de semana 👍🏻.

Copy link
Collaborator

@mateoguzmana mateoguzmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excelente trabajo, se ve muy bien en general. Solo noté unas cosas pequeñas.

src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
@Dazzae-exe
Copy link
Contributor Author

@mateoguzmana Muchas gracias Mateo, ya hice push de los cambios que me pediste 👍🏻

Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Hola, @Dazzae-exe! ¡Muchas gracias por tu contribución! Te he dejado varios comentarios sobre algunos aspectos que deberías revisar antes de poder mezclar este PR.

src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
src/content/reference/react/StrictMode.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented May 2, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mateoguzmana mateoguzmana self-requested a review May 2, 2023 04:51
@carburo carburo merged commit 602f622 into reactjs:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants