Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding translations to the <Profiler> component #633

Merged
merged 19 commits into from
Apr 2, 2023
Merged

Adding translations to the <Profiler> component #633

merged 19 commits into from
Apr 2, 2023

Conversation

RubenChirino
Copy link
Contributor

@github-actions github-actions bot added the beta label Feb 25, 2023
@carburo carburo mentioned this pull request Feb 27, 2023
Open
RubenChirino and others added 2 commits March 19, 2023 14:45
@RubenChirino @javierlopezdeancos
Update beta/src/content/reference/react/Profiler.md
5ea1245 
Co-authored-by: Javier López de Ancos <javierlopezdeancos@gmail.com>
@RubenChirino @javierlopezdeancos
Update beta/src/content/reference/react/Profiler.md
4e59325 
Co-authored-by: Javier López de Ancos <javierlopezdeancos@gmail.com>
carburo
carburo requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@carburo carburo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¡Hola! ¡Gracias por tu contribución! Te he dejado algunos comentarios que deben revisarse antes de mezclar el PR. Todos están en forma de sugerencias de GitHub que puedes aplicar o en caso que estés en desacuerdo, puedes dejar comentar en ese mismo lugar.

beta/src/content/reference/react/Profiler.md Outdated Show resolved Hide resolved
beta/src/content/reference/react/Profiler.md Outdated Show resolved Hide resolved
beta/src/content/reference/react/Profiler.md Outdated Show resolved Hide resolved
beta/src/content/reference/react/Profiler.md Outdated Show resolved Hide resolved
beta/src/content/reference/react/Profiler.md Outdated Show resolved Hide resolved
beta/src/content/reference/react/Profiler.md Outdated Show resolved Hide resolved
beta/src/content/reference/react/Profiler.md Outdated Show resolved Hide resolved
beta/src/content/reference/react/Profiler.md Outdated Show resolved Hide resolved
beta/src/content/reference/react/Profiler.md Outdated Show resolved Hide resolved
beta/src/content/reference/react/Profiler.md Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 28, 2023 •
edited
Loading

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

RubenChirino and others added 9 commits April 1, 2023 11:37
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
538b688 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
23bd321 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
5a165f7 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
5661411 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
68774eb 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
6d01292 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
df0cab3 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
c97adcc 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
f72d91b 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
RubenChirino and others added 4 commits April 1, 2023 11:41
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
32c15f4 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
8b08e8a 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
002dc38 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
@RubenChirino @carburo
Update beta/src/content/reference/react/Profiler.md
83385bc 
Co-authored-by: Rainer Martinez <rmartinezfraga@gmail.com>
@RubenChirino
Copy link
Contributor Author

Gracias @carburo y @javierlopezdeancos, he tomado sus cambios para mejorar las traducciones 🙌.

@javierlopezdeancos
Copy link
Contributor

Gracias a ti

@carburo carburo merged commit 8bc77b1 into reactjs:main Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carburo carburo carburo approved these changes

@javierlopezdeancos javierlopezdeancos Awaiting requested review from javierlopezdeancos

Assignees
No one assigned
Labels
beta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RubenChirino @javierlopezdeancos @carburo