Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Updating objects in state #563

Merged
merged 34 commits into from
Nov 2, 2022

Conversation

Alanch8
Copy link
Contributor

@Alanch8 Alanch8 commented Oct 11, 2022

No description provided.

Copy link
Contributor

@Vicenciomf1 Vicenciomf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola @Alanch8! ¡Muchas gracias por tu aporte! Para agilizar el merge de tu traducción, adjunté algunas sugerencias para que pueda cumplir con lo que se pide en la guía de estilos. Espero tengas una buena semana, ¡saludos!

beta/src/content/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/content/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/content/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/content/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/content/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/content/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/content/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/content/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/content/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
beta/src/content/learn/updating-objects-in-state.md Outdated Show resolved Hide resolved
Alanch8 and others added 13 commits November 2, 2022 09:51
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Alanch8 and others added 7 commits November 2, 2022 09:58
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
Copy link
Contributor Author

@Alanch8 Alanch8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias @Vicenciomf1. Que es lo que tengo que hacer exactamente para incorporar estas mejorar al pull?

un cordial saludo,

Co-authored-by: Vicente Martínez Fernández <101673305+Vicenciomf1@users.noreply.github.com>
@Vicenciomf1
Copy link
Contributor

Muchas gracias @Vicenciomf1. Que es lo que tengo que hacer exactamente para incorporar estas mejorar al pull?

un cordial saludo,

Hola! Respondiendo a tu pregunta, en lo personal, para estar más seguro, las pruebo en local, es decir, usar un yarn para instalar las dependencias, y un yarn dev para ver cómo quedaron, y luego subo el commit a la PR, también, suelo usar las Dev Tools para ver cómo quedaron para cada dispositivo, no obstante, no es necesario y puedes aplicarlas directamente desde las sugerencias de la review.
Pero no te preocupes, como veo, ya aplicaste tales cambios, agregaré unos cuantos que faltaron y te aviso cuando se haga el merge :) ¡Saludos!

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@Vicenciomf1
Copy link
Contributor

¡Listo! ¡Muchísimas gracias por tu aporte @Alanch8!

@Vicenciomf1 Vicenciomf1 merged commit 3ca7e19 into reactjs:main Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants