-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate invalid-hook-call-warning #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for de-reactjs ready! Built with commit 2e2e313 |
91 tasks
ph1p
requested changes
Oct 11, 2019
ph1p
added
needs review from author
First review completed. All changes are processed and a final review is required.
and removed
completed - needs review 🧐
labels
Oct 11, 2019
@michaelneu please take a look at my suggestions |
ph1p
added
the
idle
This PR is idle and the creator has not touched it for a long time.
label
Nov 17, 2019
Sorry for my extremely delayed response. I've updated the PR with your suggested changes. |
fine (: thank you |
ph1p
approved these changes
Nov 27, 2019
ph1p
removed
idle
This PR is idle and the creator has not touched it for a long time.
needs review from author
First review completed. All changes are processed and a final review is required.
labels
Nov 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure how to approach these expressions, so I settled with this: