Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Thinking in react #50

Merged
merged 20 commits into from
Jun 10, 2019
Merged

Thinking in react #50

merged 20 commits into from
Jun 10, 2019

Conversation

miku86
Copy link
Member

@miku86 miku86 commented Apr 17, 2019

No description provided.

@netlify
Copy link

netlify bot commented Apr 17, 2019 •
edited
Loading

Deploy preview for de-reactjs ready!

Built with commit 8adc800

https://deploy-preview-50--de-reactjs.netlify.com

@tesseralis tesseralis mentioned this pull request Apr 18, 2019
Closed
91 tasks
ph1p
ph1p requested changes Apr 30, 2019
View reviewed changes
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
@ph1p
Copy link
Member

ph1p commented Apr 30, 2019

Keep up the good work! 👍

@ph1p
Copy link
Member

ph1p commented May 30, 2019

@miku86 Do you have time to finish this translation because my suggestions were made some time ago?

@miku86
Copy link
Member Author

miku86 commented Jun 5, 2019

@miku86 Do you have time to finish this translation because my suggestions were made some time ago?

Thanks for the reminder.
I have blocked 2hrs on saturday for this.

miku86 and others added 10 commits June 8, 2019 17:00
@ph1p
Update content/docs/thinking-in-react.md
972f5ab 
Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/thinking-in-react.md
fffc761 
Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/thinking-in-react.md
db1a5dc 
Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/thinking-in-react.md
b6f9507 
Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/thinking-in-react.md
6c38b43 
Co-Authored-By: Phil <phil@capshake.com>
add step 3
e33ed29
add step 4
ef38969
add step 5
17b8191
add outro
ec137e8
change App and Applikation to Anwendung
2a5d197
@miku86 miku86 requested a review from ph1p June 8, 2019 16:43
@miku86 miku86 changed the title WIP: Thinking in react Thinking in react Jun 8, 2019
@miku86 miku86 added needs review from author First review completed. All changes are processed and a final review is required. completed - needs review 🧐 and removed needs review from author First review completed. All changes are processed and a final review is required. 🚧 work in progress 🚧 labels Jun 8, 2019
@miku86
Copy link
Member Author

miku86 commented Jun 8, 2019

Hey folks,
please have a in-depth look at this.
I highlighted state and props multiple times to emphasize the importance.
Thanks.

@ph1p
Copy link
Member

ph1p commented Jun 8, 2019

Great! If we don't change the meaning, I think it's okay. We should also always think about how we would like to read this document. 1:1 translation sometimes sounds really strange and I think one of our tasks is to make it readable for all developers.

ph1p
ph1p requested changes Jun 8, 2019
View reviewed changes
Copy link
Member

@ph1p ph1p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done (: I've added some suggestions, but these are only small ones.

content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
content/docs/thinking-in-react.md Outdated Show resolved Hide resolved
@ph1p ph1p added needs review from author First review completed. All changes are processed and a final review is required. and removed completed - needs review 🧐 labels Jun 9, 2019
miku86 and others added 6 commits June 10, 2019 17:19
@ph1p
Update content/docs/thinking-in-react.md
a50be48 
Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/thinking-in-react.md
25ec035 
Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/thinking-in-react.md
04a1e1d 
Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/thinking-in-react.md
a2abfa5 
Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/thinking-in-react.md
7a944e7 
Co-Authored-By: Phil <phil@capshake.com>
@ph1p
Update content/docs/thinking-in-react.md
8adc800 
Co-Authored-By: Phil <phil@capshake.com>
@ph1p ph1p removed the needs review from author First review completed. All changes are processed and a final review is required. label Jun 10, 2019
@ph1p ph1p merged commit a43f123 into master Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ph1p ph1p ph1p approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miku86 @ph1p