Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate thinking-in-react.md #318

Merged

Conversation

ameetmadan
Copy link
Contributor

No description provided.

@ChrisB9
Copy link
Collaborator

ChrisB9 commented Apr 25, 2023

Just as a hint: #26
Please change the text to 'du'

@ameetmadan ameetmadan changed the title Update thinking-in-react.md Translate thinking-in-react.md Apr 25, 2023
@ameetmadan ameetmadan marked this pull request as ready for review April 25, 2023 14:01
Copy link
Collaborator

@ChrisB9 ChrisB9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through some of the changes already and got some suggestions

src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
ameetmadan and others added 10 commits April 26, 2023 21:39
Co-authored-by: Christian Rodriguez Benthake <chris.ben9@gmail.com>
Co-authored-by: Christian Rodriguez Benthake <chris.ben9@gmail.com>
Co-authored-by: Christian Rodriguez Benthake <chris.ben9@gmail.com>
Co-authored-by: Christian Rodriguez Benthake <chris.ben9@gmail.com>
Co-authored-by: Christian Rodriguez Benthake <chris.ben9@gmail.com>
Co-authored-by: Christian Rodriguez Benthake <chris.ben9@gmail.com>
Co-authored-by: Christian Rodriguez Benthake <chris.ben9@gmail.com>
Co-authored-by: Christian Rodriguez Benthake <chris.ben9@gmail.com>
Co-authored-by: Christian Rodriguez Benthake <chris.ben9@gmail.com>
Co-authored-by: Christian Rodriguez Benthake <chris.ben9@gmail.com>
@ameetmadan
Copy link
Contributor Author

Accepted your changes, did miss some of the things which should have been obvious. Thanks for reviewing!

@ameetmadan
Copy link
Contributor Author

Is there anything left from my side to do?

@ChrisB9
Copy link
Collaborator

ChrisB9 commented May 4, 2023

@ameetmadan thanks for the reminder, no everything looked good as far as i could say.

@github-actions
Copy link

github-actions bot commented May 4, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.04 KB (🟢 -46 B) 169.67 KB
/500 76.03 KB (🟢 -46 B) 169.66 KB
/[[...markdownPath]] 77.46 KB (🟢 -46 B) 171.08 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@ChrisB9 ChrisB9 merged commit 75d898c into reactjs:main May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants