WIP Feature: Use Microsoft KeyedServiceProvider

[OleksandrTsvirkun]

Use KeyedServiceProvider instead of ContractDictionary for Splat.Microsoft.Extensions.DependencyInjection adapter.

What is the current behavior?
Splat and ServiceProvider provides different instances of a singleton object
#1074

What is the new behavior?
Splat and ServiceProvider provides the same instance of a singleton object

What might this PR break?
Nothing known.

Please check if the PR fulfills these requirements

• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

Other information:

[codecov]

Codecov Report

Attention: Patch coverage is 62.85714% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 71.79%. Comparing base (1803c70) to head (17fe3a1).
Report is 62 commits behind head on main.

Files	Patch %	Lines
...DependencyInjection/MicrosoftDependencyResolver.cs	62.85%	5 Missing and 8 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1075      +/-   ##
==========================================
- Coverage   71.87%   71.79%   -0.08%     
==========================================
  Files          96       96              
  Lines        4483     4429      -54     
  Branches      569      557      -12     
==========================================
- Hits         3222     3180      -42     
+ Misses       1074     1068       -6     
+ Partials      187      181       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dpvreony]

Thanks for your efforts on this.

can we hold, until we have a think of the overall shape of this class. my heads been running through this and I think there's gaps in the unit tests around the use of MicrosoftDependencyResolver(IServiceProvider serviceProvider) and Register that aren't related to the PR itself.

if these need cleaning up it might make sense to make MicrosoftDependencyResolver(IServiceProvider serviceProvider) become MicrosoftDependencyResolver(IKeyedServiceProvider serviceProvider) to remove a bunch of the is casts as well.

[OleksandrTsvirkun]

@dpvreony In this case should I provide these test you have mentioned?
I need to take some time to think about use cases.
Thanks for corresponding

[dpvreony]

@dpvreony In this case should I provide these test you have mentioned? I need to take some time to think about use cases. Thanks for corresponding

leave it with me

[dpvreony]

actually the net6 version supports IKeyedServiceProvider with v8 of the package. headache of framework vs packages

i'll tidy up and get this merged

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.