Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve null handling in DefaultViewLocator #2919

Merged
merged 4 commits into from
Sep 12, 2021

Conversation

glennawatson
Copy link
Contributor

@glennawatson glennawatson commented Sep 9, 2021

Co-authored-by: matej.hrlec@inel.com

@glennawatson glennawatson added the release Gets released. label Sep 9, 2021
@glennawatson glennawatson enabled auto-merge (squash) September 11, 2021 09:37
@glennawatson glennawatson enabled auto-merge (squash) September 12, 2021 02:03
@codecov
Copy link

codecov bot commented Sep 12, 2021

Codecov Report

Merging #2919 (d1981ca) into main (2be5893) will decrease coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2919      +/-   ##
==========================================
- Coverage   72.56%   72.18%   -0.39%     
==========================================
  Files         140      140              
  Lines        4906     4900       -6     
==========================================
- Hits         3560     3537      -23     
- Misses       1346     1363      +17     
Impacted Files Coverage Δ
src/ReactiveUI/View/DefaultViewLocator.cs 93.22% <100.00%> (+0.91%) ⬆️
.../ReactiveUI/Platforms/net/PlatformRegistrations.cs 57.14% <0.00%> (-28.58%) ⬇️
...iveUI/Platforms/net/ComponentModelTypeConverter.cs 52.77% <0.00%> (-19.45%) ⬇️
src/ReactiveUI.Wpf/Registrations.cs 82.35% <0.00%> (-11.77%) ⬇️
src/ReactiveUI.Winforms/Registrations.cs 82.35% <0.00%> (-11.77%) ⬇️
src/ReactiveUI/RxApp.cs 75.34% <0.00%> (-6.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be5893...d1981ca. Read the comment docs.

@glennawatson glennawatson enabled auto-merge (squash) September 12, 2021 02:45
@glennawatson glennawatson merged commit a869b29 into main Sep 12, 2021
@glennawatson glennawatson deleted the glennawatson-null-handling-default-view-locator branch September 12, 2021 03:06
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release Gets released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants