Use a prepare script for transpiling instead of prepublish #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Travis logs: As of npm@5, `prepublish` scripts will run only for `npm publish`. (In npm@4 and previous versions, it also runs for `npm install`.) See the deprecation note in `npm help scripts` for more information. This was also causing discord-irc to fail to transpile when installed using npm from source. This modifies the script to run on the `prepare` hook, so it should transpile when installed directly from source too.
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Travis logs (in the
npm installscript):As of npm@5,
prepublishscripts will run only fornpm publish.(In npm@4 and previous versions, it also runs for
npm install.)See the deprecation note in
npm help scriptsfor more information.This was also causing discord-irc to fail to transpile when installed using npm from source.
This modifies the script to run on the
preparehook, so it should transpile when installed directly from source. (npm install -g reactiflux/discord-ircfails, butnpm install -g Throne3d/discord-irc, using this patch, succeeds.)