Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doppins] Upgrade dependency irc-upd to 0.8.0 #313

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

doppins-bot
Copy link
Contributor

@doppins-bot doppins-bot commented Sep 29, 2017

Hi!

A new version was just released of irc-upd, so Doppins
has upgraded your project's dependency ranges.

Make sure that it doesn't break anything, and happy merging! :shipit:


Upgraded irc-upd from 0.7.0 to 0.8.0

Changelog:

Version 0.8.0

Breaking changes:

  • The unhandled event must not be used to catch specific events – use raw for that instead. It should be used to handle explicitly events the bot does not do anything with, such as by notifying the user that such an event has occurred
  • Errors in the raw event no longer throw, but are caught and passed to the error event. As in the documentation, this may still throw if no handler is bound to this event
  • The .join and .part methods no longer accepts space-separated lists of channels; this caused the bot to send invalid commands to the server. Instead, use comma-separated channel lists, and then the callback will be called for each channel as in the documentation
  • EventEmitter is now used directly from the require (i.e. var EventEmitter = require('events'), whereas previously var EventEmitter = require('events').EventEmitter). This fixes a bug with an atom project using the unforked node-irc version (relevant pull request (https://github.com/martynsmith/node-irc/pull/521)) but may break compatibility with old versions of node (0.x versions, as those are no longer tested against)

New features:

  • Add irc.canConvertEncoding() (aliased to client.canConvertEncoding()) to test if the library can convert different encodings with the libraries it's located
  • Add support for JOIN 0 (which, in the IRC spec, parts from all channels)
  • Handle SASL better: use the IRCv3 spec (http://ircv3.net/specs/extensions/sasl-3.1.html), and if the server does not support SASL, emit on the error event – fixes part of #38 (https://github.com/Throne3d/node-irc/issues/38)

Fixed bugs:

  • Ensure the debug config option causes the client not to output when disabled – fixes #34 (https://github.com/Throne3d/node-irc/issues/34)
  • Stop renicking properly when renickCount is hit. Previously it would renick to a second nickname and then continue the renicking process – fixes #41 (https://github.com/Throne3d/node-irc/issues/41)
  • Handle code 378 on join – fixes part of #38 (https://github.com/Throne3d/node-irc/issues/38)
  • Ensure client.action splits long messages properly (that is, it still wraps long lines in the CTCP action markers)
  • Ensure the bot disconnects immediately after programmatically calling activateFloodProtection now disconnects immediately like if opt.floodProtection is used
  • Store the data from rpl_isupport in a way that represents its structure better (objects instead of arrays for key-value pairs, and consistently parse values as integers where applicable)
  • Emit the lowercase version of the names#channel event when #channel is mixed-case
  • Clean up the automatic reconnection to the server when manually calling client.disconnect()
  • Trigger the callback to join and part even if the server channel differs in case from the one passed to client.join or client.part

Misc:

  • Add copyright notice to lib/irc.js per fork
  • Update various dependencies (coveralls, nyc)
  • Docs: Move the 'character set detection' instructions to their own section of the README
  • Docs: Mention the Gitter chat under the 'Further Support' section of the README
  • Docs: Add test coverage badge to README
  • Docs: Reorder config options and add descriptions for missing items – fixes #33 (https://github.com/Throne3d/node-irc/issues/33)
  • Docs: Improve presentation by marking things in inline code tags, instead of italics
  • Docs: Clarify that client.activateFloodProtection should only be called once per instance, not once per connection
  • Docs: Fix typos especially around new inline code blocks
  • Tests: Overhaul the whole testing system from tape to mocha
  • Tests: Improve the test.js irc client REPL
  • Tests: Add tests for a lot more of the code – this takes our coverage up from 62.614%(https://coveralls.io/builds/12716545) to 94.334% (https://coveralls.io/builds/13502071)! (#29 (https://github.com/Throne3d/node-irc/issues/29))

@coveralls
Copy link

coveralls commented Sep 29, 2017

Coverage Status

Coverage remained the same at 99.254% when pulling acde126 on doppins/irc-upd-equals-0.8.0 into ddaa2e6 on master.

@Throne3d
Copy link
Collaborator

(Changes shouldn't break anything here. I'm not sure why the changelog is a bit messed up in the formatting here – it looks fine on the actual release page.)

@ekmartin ekmartin merged commit 2fba3ee into master Sep 29, 2017
@ekmartin ekmartin deleted the doppins/irc-upd-equals-0.8.0 branch September 29, 2017 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants