Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commandCharacters to work for messages sent to Discord #221

Merged
merged 1 commit into from
May 16, 2017

Conversation

Throne3d
Copy link
Collaborator

Fixes #217.

Alter the custom formatting code somewhat (to make it easier for the next change to be implemented):

  • Reorganize the comments describing how to format the custom formatting options
  • Make 'author' and 'nickname' synonyms in the custom formatting
  • Add a 'side' parameter for commandPrelude (takes 'Discord' or 'IRC', depending on whether the message was from Discord or IRC)

Add commandCharacters support for messages sent to Discord:

  • Add functionality for command messages sent in IRC to Discord, as from Discord to IRC
  • Add debug messages upon sending command messages
  • Add tests for the above and custom formatting of it

Fixes reactiflux#217.
- Reorganize the comments describing how to format the custom
formatting options
- Make 'author' and 'nickname' synonyms in the custom formatting
- Add a 'side' parameter for commandPrelude (takes 'Discord' or
  'IRC', depending on whether the message was from Discord or IRC)
- Add debug messages upon sending command messages
- Add similar functionality for command messages sent in IRC to
  Discord, as from Discord to IRC
- Add tests for the above and custom formatting of it
@Throne3d Throne3d self-assigned this Apr 13, 2017
@coveralls
Copy link

coveralls commented Apr 13, 2017

Coverage Status

Coverage increased (+0.08%) to 98.298% when pulling 4120c59 on Throne3d:add/discord-commands into 884f0ca on reactiflux:master.

@ekmartin ekmartin merged commit a03433d into reactiflux:master May 16, 2017
@Throne3d Throne3d deleted the add/discord-commands branch May 16, 2017 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants