Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the onChange handler back to Radio inputs #481

Closed
adamkudrna opened this issue Aug 28, 2023 · 0 comments · Fixed by #502
Closed

Move the onChange handler back to Radio inputs #481

adamkudrna opened this issue Aug 28, 2023 · 0 comments · Fixed by #502
Assignees
Labels
bug Something isn't working
Milestone

Comments

@adamkudrna
Copy link
Member

adamkudrna commented Aug 28, 2023

Currently, the onChange event handler is tied onto the wrapping <fieldset> which causes React to throw the following warning:

Warning: You provided a `checked` prop to a form field without an `onChange` handler.
This will render a read-only field. If the field should be mutable use `defaultChecked`.
Otherwise, set either `onChange` or `readOnly`.

The onChange handler needs to be transferred onto individual radio inputs as it was before #466.

Don't forget to make the docs more obvious: https://react-ui.io/components/radio#forwarding-html-attributes

@adamkudrna adamkudrna converted this from a draft issue Aug 28, 2023
@adamkudrna adamkudrna added the bug Something isn't working label Aug 28, 2023
@adamkudrna adamkudrna added this to the v1.0.0 milestone Aug 28, 2023
@adamkudrna adamkudrna moved this from 🔖 To do to 🏗 In progress in The Board Sep 20, 2023
@bedrich-schindler bedrich-schindler moved this from 🏗 In progress to 👀 In review in The Board Oct 17, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in The Board Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants