Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test Docusaurus webpack 5 support #974

Merged
merged 7 commits into from
May 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions netlify.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,10 @@

[build.environment]
NODE_VERSION = "12.13"

[[plugins]]
package = "netlify-plugin-cache"
[plugins.inputs]
paths = [
"node_modules/.cache",
]
7 changes: 4 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,16 @@
"fetch-sponsors": "node scripts/fetch-sponsors.js"
},
"dependencies": {
"@docusaurus/core": "^2.0.0-alpha.72",
"@docusaurus/plugin-google-analytics": "^2.0.0-alpha.66",
"@docusaurus/preset-classic": "^2.0.0-alpha.72",
"@docusaurus/core": "2.0.0-alpha.75",
"@docusaurus/plugin-google-analytics": "2.0.0-alpha.75",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @slorber for your PR! just one small thing to check before we land it.

@brentvatne could you check if this new version GA plugin still working the analytics?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Do you expect me to do anything?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, all looks good to me @slorber, thanks again for your awesome work on docusarus.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eriveltonelias - i can add you to the google analytics account, dm me on discord to let me know what email to add :)

"@docusaurus/preset-classic": "2.0.0-alpha.75",
"@octokit/graphql": "^4.5.7",
"@react-navigation/core": "^5.14.3",
"classnames": "^2.2.6",
"docsearch.js": "^2.6.3",
"escape-html": "^1.0.3",
"mkdirp": "^1.0.4",
"netlify-plugin-cache": "^1.0.3",
"prism-react-renderer": "^1.1.1",
"react": "^17.0.1",
"react-dom": "^17.0.1",
Expand Down
Loading