Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remark SnackPlayer tweaks #33

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Remark SnackPlayer tweaks #33

merged 3 commits into from
Oct 9, 2020

Conversation

Simek
Copy link

@Simek Simek commented Oct 8, 2020 •
edited
Loading

This PR updates the remark-snackplayer plugin and introduces the following changes:

  • basic theme support (via theme parameter)
  • allow to set preview parameter value
  • default platform fallback changed to web
  • Snack Player embedded script injection removed
    • it is now a part of installation process described in readme
  • inline style has been replaced with class to make styling the player flexible
    • a note about styling has been added to the Readme file
  • updated tests and test outputs
    • but they are failing on Windows due to different EOL sign expected, but I have tried my best 🙂
    • I was able to force correct EOL and fix the tests
  • various other Readme file tweaks

Dark theme preview

Screenshot 2020-10-08 202304

@Simek Simek requested a review from darshkpatel October 8, 2020 18:44
@Simek Simek mentioned this pull request Oct 8, 2020
Closed
darshkpatel
darshkpatel approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@darshkpatel darshkpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darshkpatel
Copy link
Member

How do you think should the light-dark theme switching be implemented?

@Simek
Copy link
Author

Simek commented Oct 9, 2020 •
edited
Loading

How do you think should the light-dark theme switching be implemented?

@darshkpatel Probably @slorber have the best set of knowledge to answer that. 🙂

From the Expo side I got a tip that the theme can be changed (even without reloading Snacks) by posting message to iframe.

@Simek Simek merged commit 66862ae into dev Oct 9, 2020
Simek added a commit that referenced this pull request Oct 20, 2020
@Simek
Remark SnackPlayer tweaks (#33)
6bd1fdb 
* remark-snackplayer: add theme, move styling, update readme, update tests

* remark-snackplayer: add missing class to test output

* remark-snackplayer: add preview param, force LF EOL, fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darshkpatel darshkpatel darshkpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Simek @darshkpatel