WIP: SnackPlayer Plugin #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JavaScript heap out of memory 😢 |
Simek
reviewed
Oct 5, 2020
|
FYI I've added the ability to reinitialize snackplayer on route change and tab change. It's a bit hacky IMHO but seems to work fine (sometimes snack iframe takes some time to init though). Pinged Satya to see if this integration can be made easier directly inside the embedded snack js script. @darshkpatel as I msged you in private I think it's better if we reintegrate the snackplayer temporarily as it's easier to fix issues for now. We'll figure out where this plugin should live after it works fine. |
|
@slorber Done |
|
LGTM, but will let @Simek merge if it's fine ;) |
Simek
approved these changes
Oct 7, 2020
Simek
added a commit
that referenced
this pull request
Oct 20, 2020
* add remark-snackplayer * bump version * remove legacy plugins * Increase heap memory * move heap fix to the deployment scripts * Add ability to initialize snackplayer after navigation and tab changes * add local remark-snackplayer package * cleanup package * Fix: dependency issues Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com> Co-authored-by: slorber <lorber.sebastien@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've published v0.0.1 of the remark plugin called remark-snackplayer
This is with reference to #4
I'll be opening a followup PR to fix the following issues: