add additional languages and customize prism theme #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is ready for review now 🙂 |
Simek
approved these changes
Sep 14, 2020
There was a problem hiding this comment.
Thank you @teikjun, this is looking way better! 🙂
I had to remove the lines highlight (https://prismjs.com/plugins/line-highlight/ - can we support this feature in the later time too? currently specifying lines is breaking the code highlight) and I have renamed the Prism theme file just for the readability. Other than that changes LGTM! 👍
Simek
added a commit
that referenced
this pull request
Oct 20, 2020
* add additional languages for prism * set up custom theme for prism * customize according to solarized dark theme * add custom syntax highlighting from react-native * rename theme file, add Kotlin, fix one ObjC block Co-authored-by: Bartosz Kaszubowski <gosimek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
Preview
Known issues
There are 2 known issues with objectivec code snippets
/docs/native-components-ios, there is an objectivec codeblock that does not have syntax highlighting.It cannot be tokenized for unknown reason.
For example, both # and <...> are both treated as the same type of token now, making it impossible to give them distinct colors.