yarn_install - add optional yarn_install_directory parameter

[joshdholtz]

Motivation

Similar to pod_install's pod_install_directory parameter, this adds a yarn_install_directory to yarn_install

Description

Sometimes the package.json file isn't in the current/root directory so this option allows for project configurations where the package.json file is somewhere else

• Defaults to an empty string which will run as previously did yarn install
• Runs yarn --cwd <<yarn_install_directory>> if any non-empty string value is used

Example

- yarn_install:
    yarn_install_directory: examples/oneOfMyExampleApps
    cache_folder: ~/.cache/yarn

[vonovak]

this looks good to me, but may I have a question?

yarn install has a bunch of parameters, and I don't think we want to support all of the parameters in the yarn_instal command - the command is just a proxy to yarn install itself.

@joshdholtz wouldn't it make more sense for people who need more customizations to just run yarn install --xyz with whichever params they need? Is there a reason that's not possible currently?

Thanks for your opinions :)

[joshdholtz]

@vonovak I thought --cwd is a special parameter and actually needs to precede that yarn command. I thought I saw and tried yarn install --cwd <dir> and that didn't work and that it had to be yarn --cwd <dir> install... But I think I was wrong 😅

Are you thinking of making this parameter generic like extra_yarn_options so I could do:

- yarn_install:
    yarn_options: --cwd examples/oneOfMyExampleApps --verbose
    cache_folder: ~/.cache/yarn

Or something like that? ☝️

[vonovak]

hi, thanks for explaining. What I had in mind was not relying on the yarn_install command provided by this package at all, like here:

https://github.com/react-native-datetimepicker/datetimepicker/blob/85c7a701677b60d86bef498fcd470cc67197c200/.circleci/config.yml#L21

ie. if people need special parameters, allow them to run yarn install whichever way they want.

the yarn_install command provided by this package would only be for the very simplest use cases, or perhaps could be removed altogether. But I'm not knowledgeable enough of the repo to be able to say if it makes sense and/or if it's possible... :)

[joshdholtz]

@vonovak Ahhh, I see! 😊 That is essentially what we are doing right now 👉 https://github.com/RevenueCat/react-native-purchases/blob/purchase-tester-typescript/.circleci/config.yml#L10-L60

Usage here 👉 https://github.com/RevenueCat/react-native-purchases/blob/purchase-tester-typescript/.circleci/config.yml#L104-L120

We use other commands from the ReactNative orb and yarn_install is almost perfect for us to use (the caching built in is super nice) but doesn't work well with our example projects (because in sub directories). I figured that if we had this problem that others might have the same problem as well so just wanted to contribute back 😊

I'm totally fine if this is too much for this command but it just didn't feel write to copy it, change it, and not submit our changes upstream 🙃

[react-native-community-bot]

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

• CircleCI Orb
• GitHub release

Your semantic-release bot 📦🚀