Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: launchEditor not working for JetBrains IDEs #2197

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix: launchEditor not working for JetBrains IDEs #2197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/cli-tools/src/launchEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,6 @@ function getArgumentsForLineNumber(
case 'Atom Beta':
case 'subl':
case 'sublime':
case 'webstorm':
case 'wstorm':
case 'appcode':
case 'charm':
case 'idea':
return [`${fileName}:${lineNumber}`];
case 'joe':
case 'emacs':
Expand All @@ -91,6 +86,11 @@ function getArgumentsForLineNumber(
case 'rmate':
case 'mate':
case 'mine':
case 'webstorm':
case 'wstorm':
case 'appcode':
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AppCode is no longer available:
https://www.jetbrains.com/objc/

Copy link
Contributor

@liamjones liamjones Dec 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still available to existing users (if that makes a difference)

Edit: Sorry, by that I mean there will be people with perpetual licenses for it and it'll work until Apple change something that breaks it working anymore.

case 'charm':
case 'idea':
return ['--line', String(lineNumber), fileName];
case 'code':
case 'code-insiders':
Expand Down
Loading