Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gradlew doctor check permissions #2191

Merged
merged 3 commits into from
Dec 11, 2023
Merged

feat: add gradlew doctor check permissions #2191

merged 3 commits into from
Dec 11, 2023

Conversation

jeferson-sb
Copy link
Contributor

@jeferson-sb jeferson-sb commented Dec 1, 2023 •
edited
Loading

Summary:

Feature request #2127

Test Plan:

For now,

  • yarn build
  • cd AwesomeProject && chmod -u ./android/gradlew
  • node ~/path/to/cli/packages/cli/build/bin.js doctor

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@jeferson-sb jeferson-sb marked this pull request as ready for review December 3, 2023 23:57
@jeferson-sb jeferson-sb requested a review from adamTrz as a code owner December 3, 2023 23:57
szymonrybczak
szymonrybczak approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@thymikee thymikee merged commit 1c9d669 into react-native-community:main Dec 11, 2023
8 of 10 checks passed
thymikee pushed a commit that referenced this pull request Dec 11, 2023
@jeferson-sb @thymikee
feat: add gradlew doctor check permissions (#2191)
73cf093 
* feat: add gradlew doctor check permissions

* feat: add gradle to android healthchecks list

* feat: use config object to get android path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee left review comments

@szymonrybczak szymonrybczak szymonrybczak approved these changes

@TMisiukiewicz TMisiukiewicz TMisiukiewicz approved these changes

@adamTrz adamTrz Awaiting requested review from adamTrz adamTrz is a code owner

@cortinico cortinico Awaiting requested review from cortinico

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeferson-sb @thymikee @TMisiukiewicz @szymonrybczak