fix: check for main manifest if multiple are present #2174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes a newly introduced (#1967) problem that having multiple build flavors in app causes the
findManifest
script to take the first found one. We think it seems more reasonable to take the one frommain
folder, if present. It fixes the error inExpensify
app, wheree2e
manifest is the first found one, and theMainActivity
is present in themain
folder'sAndroidManifest.xml
. It throws such error then:Test Plan:
Make a simple app with
activity
tag insidemain
AndroidManifest.xml
and add a directory e.g.e2e
with otherAndroidManifest.xml
, which should have theactivity
merged from themain
. It will cause the error on gradle sync in RN 0.73.xChecklist