This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Shape and Text Shadows #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome !! |
Esemesek
reviewed
Dec 18, 2019
Esemesek
reviewed
Dec 18, 2019
|
@Esemesek typings are updated and the merge conflict is resolved. |
Esemesek
approved these changes
Dec 19, 2019
|
Thank you for contributing <3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I needed shapes with shadows.
Test Plan
Tested using the example app. The Text has a blue shadow and the heart has a red shadow. (On Android the heart shadow is very faint)
IOS Example App
Android Example App
Compatibility
Checklist
README.mdCHANGELOG.mdexample/App.js)