Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid body scrolling when dialog open #19

Merged
merged 3 commits into from
Mar 17, 2016

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Mar 16, 2016

#9

@yiminghe
Copy link
Member

嗯,看起来不错。我在想一开始为什么不和 bootstrap 结构一致...

@yesmeck
Copy link
Member Author

yesmeck commented Mar 17, 2016

我还有个疑问就是 close 的时候,为什么不把 Dialog unmount 掉?像我在 modal 里用了redux-form,它会在 unmount 的时候做一些事。但是现在 Dialog 不 unmount,导致配合 redux-form 会有些问题。

@yiminghe
Copy link
Member

show? <Modal /> : null

自己控制

@yesmeck
Copy link
Member Author

yesmeck commented Mar 17, 2016

这样就会碰到这个问题 #18

yiminghe added a commit that referenced this pull request Mar 17, 2016
Avoid body scrolling when dialog open
@yiminghe yiminghe merged commit 8e34b22 into react-component:master Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants