feat: retire deprecated api #357

aojunhao123 · 2025-01-04T14:44:45Z

ref Ant Design v6 tasks ant-design/ant-design#52115

Summary by CodeRabbit

Git 忽略文件更新
- 添加 bun.lockb 到忽略列表
- 添加 .vscode/ 目录到忽略列表
组件重构
- 移除 Collapse 组件中的废弃警告和 Panel 导出
- 简化 useItems 钩子，移除 rawChildren 处理
测试调整
- 重构测试用例，使用 items 属性替代直接子组件
- 更新测试以确保 Collapse 组件的核心功能和行为一致性

vercel · 2025-01-04T14:44:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
collapse	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 4, 2025 3:01pm

coderabbitai · 2025-01-04T14:44:51Z

Warning

Rate limit exceeded

@aojunhao123 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 56 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 2e300a5 and 53ad359.

📒 Files selected for processing (4)

docs/demo/fragment.md (0 hunks)
docs/examples/custom-icon.tsx (3 hunks)
docs/examples/fragment.tsx (0 hunks)
docs/examples/simple.tsx (3 hunks)

总览

代码变更概述

代码变更详情

代码走查

这些变更主要涉及 Collapse 组件的重构和简化。主要包括移除已弃用的 Panel 导出，更新 useItems 钩子以仅支持 items 属性，并更新测试用例以反映新的组件结构。变更旨在清理组件 API，移除过时的功能，并简化组件的使用方式。

变更

文件	变更摘要
`.gitignore`	添加 `bun.lockb` 和 `.vscode/` 到忽略列表
`src/Collapse.tsx`	移除警告导入，移除 `children` 属性，简化导出
`src/hooks/useItems.tsx`	移除 `rawChildren` 参数，简化函数实现
`src/index.tsx`	删除 `Panel` 导出
`tests/index.spec.tsx`	更新测试用例，使用 `items` 属性替代 `Panel` 子组件

序列图

sequenceDiagram
    participant User
    participant Collapse
    participant Items
    User->>Collapse: 传入 items 数组
    Collapse->>Items: 转换 items 为节点
    Items-->>Collapse: 返回渲染节点
    Collapse-->>User: 渲染折叠面板

诗歌

🐰 折叠的魔法，简单如兔跳
API 清新似春风轻拂
告别复杂，拥抱优雅
代码如诗，兔子微笑
重构的节奏，轻盈飞翔 🌈

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-01-04T14:56:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.83%. Comparing base (14034b7) to head (53ad359).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
- Coverage   99.12%   98.83%   -0.29%     
==========================================
  Files           5        4       -1     
  Lines         114       86      -28     
  Branches       43       33      -10     
==========================================
- Hits          113       85      -28     
  Misses          1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zombieJ · 2025-01-07T06:33:35Z

src/Collapse.tsx

-  );
-
-  const mergedChildren = useItems(items, children, {
+  const mergedChildren = useItems(items, {


antd v4 还是 jsx 的，v5 是在 5.6.0 进行的 depreacted，v6 还得兼容一版。但是文档里不透出老的写法

feat: retire deprecated api

bd23614

fix: lint fix

2e300a5

vercel bot had a problem deploying to Preview January 4, 2025 14:50 Failure

chore: update demo

3fa129b

chore: update demo

53ad359

vercel bot deployed to Preview January 4, 2025 15:01 View deployment

aojunhao123 mentioned this pull request Jan 4, 2025

Ant Design v6 tasks ant-design/ant-design#52115

Open

zombieJ reviewed Jan 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: retire deprecated api #357

feat: retire deprecated api #357

aojunhao123 commented Jan 4, 2025 •

edited

Loading

vercel bot commented Jan 4, 2025 •

edited

Loading

coderabbitai bot commented Jan 4, 2025 •

edited

Loading

Rate limit exceeded

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented Jan 4, 2025 •

edited

Loading

zombieJ Jan 7, 2025

feat: retire deprecated api #357

Are you sure you want to change the base?

feat: retire deprecated api #357

Conversation

aojunhao123 commented Jan 4, 2025 • edited Loading

Summary by CodeRabbit

vercel bot commented Jan 4, 2025 • edited Loading

coderabbitai bot commented Jan 4, 2025 • edited Loading

Rate limit exceeded

总览

代码变更概述

代码变更详情

代码走查

变更

序列图

诗歌

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented Jan 4, 2025 • edited Loading

Codecov Report

zombieJ Jan 7, 2025

Choose a reason for hiding this comment

aojunhao123 commented Jan 4, 2025 •

edited

Loading

vercel bot commented Jan 4, 2025 •

edited

Loading

coderabbitai bot commented Jan 4, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jan 4, 2025 •

edited

Loading